Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removes Redux state mutations - iteration 1 #23522

Merged
merged 3 commits into from
Mar 31, 2023
Merged

fix: Removes Redux state mutations - iteration 1 #23522

merged 3 commits into from
Mar 31, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This iteration removes Redux state mutations from the codebase to allow us to merge #23460 without disrupting the development workflow.

TESTING INSTRUCTIONS

1 - Pull changes from #23460 to enable the immutabilityMiddleware
2 - Edit a dashboard and save it
3 - You shouldn't see any errors related to state mutation

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #23522 (4ff99da) into master (80d1e4f) will increase coverage by 0.05%.
The diff coverage is 67.78%.

❗ Current head 4ff99da differs from pull request most recent head df9d21e. Consider uploading reports for the commit df9d21e to get more accurate results

@@            Coverage Diff             @@
##           master   #23522      +/-   ##
==========================================
+ Coverage   67.63%   67.68%   +0.05%     
==========================================
  Files        1910     1914       +4     
  Lines       73747    73956     +209     
  Branches     7988     8029      +41     
==========================================
+ Hits        49879    50059     +180     
- Misses      21826    21851      +25     
- Partials     2042     2046       +4
Flag Coverage Δ
javascript 53.91% <57.79%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <ø> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
...plugins/legacy-plugin-chart-world-map/src/index.js 66.66% <ø> (ø)
...tend/plugins/legacy-preset-chart-nvd3/src/utils.js 15.92% <ø> (ø)
.../plugins/plugin-chart-echarts/src/BoxPlot/index.ts 50.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts 50.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx 0.00% <0.00%> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/index.ts 50.00% <ø> (ø)
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <0.00%> (ø)
... and 111 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 1ced7cd into apache:master Mar 31, 2023
@justinpark justinpark mentioned this pull request Apr 3, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @justinpark @mistercrunch